Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 1M EDMF (diag and prog) on GPU #3070

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Test 1M EDMF (diag and prog) on GPU #3070

merged 1 commit into from
Jun 7, 2024
+74 −30

Conversation

trontrytel
Copy link
Member

This PR makes EDMFX (prognostic and diagnostic) work with 1M microphysics on the GPU. Thank you @charleskawczynski !

@szy21 - I wasn't sure if you would like to also keep the 0M edmf aquaplanet runs in the CI?

@trontrytel trontrytel self-assigned this Jun 5, 2024
szy21
szy21 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't have to keep the 1M one. Why does this change make it work on GPU?

@trontrytel
Copy link
Member Author

You mean you want to keep the 0M in the GPU CI? Not the 1M? I think it would be good to have 1M tests on the GPU. Maybe we can add both then?

For diagnostic edmf we had to flatten the detrainment function signature to pass less things in. For prognostic edmf it's a bug in ClimaCore. Once it's fixed I should be able to use the normal fill (i.e. @. blah = FT(0) instead of @. blah = FT(0) * blah2)

charleskawczynski
charleskawczynski approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, it's possible that this additional entrainment method may not even be needed after CliMA/ClimaCore.jl#1782 🤞🏻. That said, I think it's a good idea to merge this before that

@szy21
Copy link
Member

szy21 commented Jun 6, 2024

You mean you want to keep the 0M in the GPU CI? Not the 1M? I think it would be good to have 1M tests on the GPU. Maybe we can add both then?

For diagnostic edmf we had to flatten the detrainment function signature to pass less things in. For prognostic edmf it's a bug in ClimaCore. Once it's fixed I should be able to use the normal fill (i.e. @. blah = FT(0) instead of @. blah = FT(0) * blah2)

Sorry that was a typo (I was replying while explaining edmf equations to others lol). I meant we don't need to keep the 0M one.

@trontrytel trontrytel enabled auto-merge June 7, 2024 18:12
@trontrytel trontrytel added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 4bcc2a2 Jun 7, 2024
11 checks passed
@trontrytel trontrytel deleted the aj/gpu_edmf_1M branch June 7, 2024 19:46
@szy21 szy21 mentioned this pull request Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysridhar akshaysridhar akshaysridhar left review comments

@szy21 szy21 szy21 approved these changes

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees

@trontrytel trontrytel

Labels
Microphysics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trontrytel @szy21 @charleskawczynski @akshaysridhar